fix: rewrite use_rslora literal assert in test_issue1090_fu5_round (red on main)
kind: infra
track:Highlight text on any card (body, plan, or an event) to anchor a comment, or leave a whole-task comment here. Mention @claude to summon a reply.
No comments yet.
Overview / Motivation
Filed by the #1660 orchestrator from an implementer-surfaced finding (2026-07-24): a test red on pristine origin/main, polluting every Step 9c / merge-gate baseline until fixed. NOT a workflow-surface fix — experiment-pinning test code.
Goal
Make tests/test_issue1090_fu5_round.py::test_fmt_pers_r256_train_config_carries_rank assert the rsLoRA contract in a literal-drift-proof way so it passes on main while still pinning the behavior it was written to pin.
Bug
- Observed: the test asserts
"use_rslora=True" in inspect.getsource(train_lora), but main'strain_loranow threadsuse_rslora=cfg.use_rslora(sft.py L1489) with the default carried by theTrainLoraConfig.use_rslora: bool = Truefield (L605) — the literal survives only in a comment (L601), OUTSIDEtrain_lora's source. The assert fails on pristine main. - Why it matters: a permanently-red main test degrades the known-red ledger and burns per-branch triage; it also contradicts the sibling pin
tests/test_train_lora_config_use_rslora.py, which already pins the field-based contract. - Fix shape: rewrite the assert to the field-based contract —
TrainLoraConfig().use_rslora is Trueplus the threading pin"use_rslora=cfg.use_rslora" in inspect.getsource(train_lora)— preserving the test's r=256/alpha=64 rank assertions unchanged. - verified-at-filing:
grep -n "use_rslora" src/explore_persona_space/train/sft.py→ literaluse_rslora=Trueonly at L601 (comment); live probeuv run python -c "import inspect; from explore_persona_space.train.sft import train_lora; print('use_rslora=True' in inspect.getsource(train_lora))"→False(2026-07-24). Failing assert at tests/test_issue1090_fu5_round.py:204.
Scope
tests/test_issue1090_fu5_round.pyonly (the assert at L204 and any sibling literal-asserts in the same test). Do NOT touchsrc/explore_persona_space/train/sft.py— the behavior is intact and separately pinned.
Activity